[release/6.0-rc2] Fixup OpenAPI displayed param type when using TryParse #36588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
javiercn and
pranavkm
as code owners
ghost
added
the
area-mvc
Member
|
@Pilchie Another change for RC2 |
captainsafia
approved these changes
Sep 16, 2021
Member
|
Approved for RC2. |
Member
|
@dotnet/aspnet-build merge please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36555 to release/6.0-rc2
/cc @BrennanConroy
Customer Impact
Better display the route/query string type when using tools like swashbuckle. Before it was always object for complex types, now it will properly show string for complex types.
Testing
Tested against swashbuckle, behavior changed to be what we wanted
Risk
Low, not a critical code path, mostly used by tools to generate information about endpoints.