Revert setting endpoint name automatically #36518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
captainsafia
added
old-area-web-frameworks-do-not-use
captainsafia
force-pushed
the
safia/revert-auto-endpoint-name
branch
from
8753842 to
b182f1c
Compare
Member
|
Do we assert that name is not set anywhere when using a method group? |
captainsafia
force-pushed
the
safia/revert-auto-endpoint-name
branch
from
b182f1c to
0301159
Compare
Member
Author
I added one. This is the only place we set the endpoint name by default within the framework but doesn't hurt to add a check for it I guess. 🤷🏽♀️ |
davidfowl
approved these changes
Sep 15, 2021
Member
Author
|
@dotnet/aspnet-build Can I get help merging this? |
captainsafia
added a commit
that referenced
this pull request
Sep 15, 2021
captainsafia
added a commit
that referenced
this pull request
Sep 15, 2021
halter73
added a commit
to dotnet/AspNetCore.Docs
that referenced
this pull request
Oct 28, 2022
- Reverted in .NET 6 RC 2: dotnet/aspnetcore#36518
halter73
added a commit
to dotnet/AspNetCore.Docs
that referenced
this pull request
Oct 28, 2022
- Reverted in .NET 6 RC 2: dotnet/aspnetcore#36518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #35439.
I undid the change that sets the endpoint name metadata from the method name. I kept the code that sets the method name in the display name for the route since I think that is still helpful.
Closes #36487