Unquarantine Caching_SendFileWithFullContentLength_Cached #36430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
ghost
added
the
Tratcher
approved these changes
Sep 12, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
I recall these were flakiest on Win7 which we've now removed from the test matrix.
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through history, it doesn't look like this test has ever failed while in quarantine (going back to 5/25). The change which quarantined it also changed the max-age setting in the Cache-Control header which likely helped.
I'm thinking it's safe to unquarantine based on that, but could also be convinced that we should harden it further before doing so.
Thoughts?
@Tratcher
Fixes #32853