Skip to content

Use one-shot static hash methods #36368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2021
Merged

Use one-shot static hash methods #36368

merged 5 commits into from
Sep 13, 2021

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Sep 10, 2021 •
edited
Loading

PR Title

Use one-shot static hash methods

PR Description

  • Use one-shot static HashData() methods for SHA1 and HMACSHA*.
  • Fix or update some documentation links.
  • Expand the test coverage for the TwitterHandler class based on the Facebook handler's tests.
  • Minor readability change to use Convert.ToHexString() in a test helper.

@martincostello
Use one-shot static hash methods
dcbc310 
Use one-shot static hash methods for SHA1 and HMACSHA*.
Also a readability change to use Convert.ToHexString().
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 10, 2021
@martincostello
Assert on appsecret_proof
7b8c070 
Assert that the correct secret proof is added to the request URL.
@martincostello
Update URL
a7b9e8c 
Update URL that redirects.
@martincostello
Copy link
Member Author

martincostello commented Sep 10, 2021

While I was playing around with Javier's suggestion I found that the tests didn't explicitly assert on the appsecret_proof value generated by the Facebook handler, so I've added an assert for that. I also updated a link that now redirects elsewhere.

@javiercn javiercn mentioned this pull request Sep 10, 2021
Open
@martincostello
Fix invalid documentation link
ae79308 
Update link that resulted in a 404.
@martincostello
Expand TwitterHandler coverage
8144485 
Add test coverage for CreateTicketAsync(), ObtainAccessTokenAsync() and RetrieveUserDetailsAsync().
@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Sep 10, 2021
@Tratcher Tratcher merged commit 6f5d122 into dotnet:main Sep 13, 2021
@Tratcher
Copy link
Member

Tratcher commented Sep 13, 2021

Thanks

@ghost ghost added this to the 7.0-preview1 milestone Sep 13, 2021
@martincostello martincostello deleted the Use-OneShot-Hashes branch September 13, 2021 16:04
@martincostello martincostello mentioned this pull request Sep 19, 2021
Merged
@davidfowl davidfowl added the Perf label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees

No one assigned

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member Perf

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@martincostello @Tratcher @javiercn @davidfowl @Pilchie