Skip to content

Fix templates #36255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2021
Merged

Fix templates #36255

merged 3 commits into from
Sep 8, 2021

Conversation

@jmprieur
Copy link
Contributor

@jmprieur jmprieur commented Sep 8, 2021 •
edited
Loading

  • [ x] You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Update ASP.NET Core Web project templates

PR Description

  • Updated Microsoft.Identity.Web version
  • Fixed the missing scopes in appsettings.json for the web API and the Blazorwasm hosted server project
  • Added more pages to the blazorwasm hosted project for AAD (to call graph and a downstream API)

Fixes #bugnumber (in this specific format)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 8, 2021
jmprieur
jmprieur commented Sep 8, 2021
View reviewed changes
...tTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Server/appsettings.json
// "ClientCertificates" : [
// ],
//#endif
// "Scopes": "api-scope",
Copy link
Contributor Author

@jmprieur jmprieur Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protected web APIs always require scopes or app role

Copy link
Contributor Author

@jmprieur jmprieur Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the web API, and mvc with b2c for Edit Profile.

Copy link
Contributor Author

@jmprieur jmprieur Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoK FYI

@jmprieur jmprieur marked this pull request as ready for review September 8, 2021 04:03
@jmprieur jmprieur requested review from a team, Pilchie and dougbu as code owners September 8, 2021 04:03
@HaoK HaoK merged commit a0182f0 into dotnet:release/6.0 Sep 8, 2021
@ghost ghost added this to the 6.0-rc2 milestone Sep 8, 2021
@HaoK
Copy link
Member

HaoK commented Sep 8, 2021

/backport to main

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Started backporting to main: https://github.com/dotnet/aspnetcore/actions/runs/1213966481

@github-actions github-actions bot mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0-rc2

Development

Successfully merging this pull request may close these issues.

2 participants

@jmprieur @HaoK