Skip to content

Fix sample usage for --format argument #36009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix sample usage for --format argument #36009

merged 1 commit into from
Sep 7, 2021

Conversation

@reduckted
Copy link
Contributor

@reduckted reduckted commented Sep 1, 2021

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
The argument --key-format was changed to --format in #23803, but the example usage wasn't updated. This PR updates that argument in the example usage.

PR Description

Fixes #36008

@reduckted
Fix sample usage for --format argument
b42ca0f 
The argument `--key-format` was changed to `--format` in dotnet#23803, but the sample usage wasn't updated.
@reduckted reduckted requested a review from Pilchie as a code owner September 1, 2021 05:14
@ghost ghost added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI community-contribution Indicates that the PR has been added by a community member labels Sep 1, 2021
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Sep 1, 2021

Thanks for your PR, @reduckted.
@pranavkm can you please review this? Thanks!

@pranavkm pranavkm merged commit c085e17 into dotnet:main Sep 7, 2021
@ghost ghost added this to the 7.0-preview1 milestone Sep 7, 2021
@pranavkm
Copy link
Contributor

pranavkm commented Sep 7, 2021

Thanks for the PR!

@reduckted reduckted deleted the patch-1 branch September 7, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pilchie Pilchie Awaiting requested review from Pilchie

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pranavkm pranavkm

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

dotnet dev-certs tool prints incorrect example usage

3 participants

@reduckted @mkArtakMSFT @pranavkm