[release/6.0] Complain when returning IActionResult from MinimalAction #35710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionResultsFromMapMethodsTest.cs
ghost
added
the
area-infrastructure
BrennanConroy
approved these changes
Aug 25, 2021
| var compilation = compilationStartAnalysisContext.Compilation; | ||
| if (!WellKnownTypes.TryCreate(compilation, out var wellKnownTypes)) | ||
| { | ||
| Debug.Fail("One or more types could not be found. This usually means you are bad at spelling C# type names."); |
Member
There was a problem hiding this comment.
you are bad at spelling C# type names
Haha, what kind of message is this 😆
| // if we don't have a method body, and the action is IResult or ActionResult<T> returning, produce diagnostics for the entire method. | ||
| context.ReportDiagnostic(Diagnostic.Create( | ||
| DiagnosticDescriptors.DoNotReturnActionResultsFromMapActions, | ||
| invocationOperation.Arguments[2].Syntax.GetLocation(), |
Member
There was a problem hiding this comment.
Should there be a comment showing what the operation looks like so we know what Arguments[2] is?
Contributor
There was a problem hiding this comment.
I guess, maybe we want to do this in the PR to main?
Contributor
|
@dotnet/aspnet-build merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35572 to release/6.0
/cc @pranavkm
Customer Impact
Testing
Risk