Skip to content

Conversation

@halter73
Copy link
Member

This should be a long similar to CorrelationIdGenerator._lastId now that we don't mod the value stored in _settingsIndex after incrementing.

@halter73 halter73 force-pushed the halter73/long-settingsIndex branch from e2e781c to 7500fe1 Compare August 16, 2021 17:31
@davidfowl
Copy link
Member

Good catch. Was it long before?

@halter73
Copy link
Member Author

Good catch. Was it long before?

No, but it never grew past _settingsCount which is an int.

_settingsIndex = (_settingsIndex + 1) % _settingsCount;

@halter73 halter73 merged commit 6acac81 into main Aug 16, 2021
@halter73 halter73 deleted the halter73/long-settingsIndex branch August 16, 2021 21:20
@ghost ghost added this to the 6.0-rc1 milestone Aug 16, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants