Enable RazorSourceGenerator all the time #35391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that 17.0 p3 is public, we could require it and make the source generator default. The rc1 SDK we use already requires new compiler features
ghost
added
the
area-infrastructure
Member
|
So this officially makes VS 17.0 a requirement? Or was it already as of our most recent SDK update? CC @dotnet/aspdoi who might have some opinions here |
Contributor
Author
|
Yup, it makes it a requirement. I think having global usings enabled already makes it a pre-req, |
captainsafia
approved these changes
Aug 16, 2021
Member
|
I think having Dev 17 as a requirement is fine, you can't already use dev16 for dev on the repo anyways (last time I tried), I don't think this changes anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that 17.0 p3 is public, we could require it and make the source generator default. The rc1 SDK we use already requires new compiler features