Set route name metadata in WithName #35388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
captainsafia
requested review from
BrennanConroy,
DamianEdwards,
davidfowl and
halter73
DamianEdwards
approved these changes
Aug 16, 2021
halter73
reviewed
Aug 16, 2021
| public static TBuilder WithName<TBuilder>(this TBuilder builder, string endpointName) where TBuilder : IEndpointConventionBuilder | ||
| { | ||
| builder.WithMetadata(new EndpointNameAttribute(endpointName)); | ||
| builder.WithMetadata(new EndpointNameAttribute(endpointName), new RouteNameMetadata(endpointName)); |
Member
There was a problem hiding this comment.
I see that both IEndpointNameMetadata and IRouteNameMetadata have been around in the same namespace and assembly since at least 3.0. The doc comments for both indicate that they're used for link-generation.
@pranavkm @JamesNK Do either of you know why we have a route name and an enpoint name and how they're used differently?
Member
There was a problem hiding this comment.
Sorry, I don't know. I didn't touch link generation much. When I worked on routing I focused on endpoint generation and route matching.
davidfowl
approved these changes
Aug 16, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35314.