Fix FileLoggerProcessorTests #35305
Merged
Fix FileLoggerProcessorTests #35305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Yep, mark them, leave them open, and someone should check them in 30 days. |
BrennanConroy
approved these changes
Aug 13, 2021
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #34982, #34986
These tests wait for a file to exist before disposing the
FileLoggerProcessor, but the file exists before it gets written to, so the tests could dispose the logger before it writes, causing the tests to fail. Changing them so they wait until the file exists & has content before disposing. Running these in a loop locally to see if they still fail for me, won't merge this until that's green.@BrennanConroy remind me of the process here - just mark the 2 test issues "test-fixed" & build-ops will unquarantine after a month if they haven't failed?