Restore debugging support in WebAssembly hosted template #35294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
approved these changes
Aug 12, 2021
Member
Author
There was a problem hiding this comment.
It was randomly inconsistent with the MainLayout.Auth.razor file. I think the link I've put here is the correct one out of the two.
Also I've moved these changes to a separate PR now: #35296
SteveSandersonMS
force-pushed
the
stevesa/fix-wasm-hosted-debugging
branch
from
244a690 to
cae1a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/814
A recent change resulted in the
UseWebAssemblyDebuggingcall only being included for projects with individual auth. This is incorrect, since it should in included regardless of auth settings.Additionally, the way the
#if/#else/#endifpragmas were used was very hard to read, probably leading to the above mistake - they were trying to minimize the number of such pragmas at the cost of deliberately mismatching C# scope boundaries. To make these files readable, we should ensure that#ifblocks are correctly nested inside C# scopes (and vice-versa) as if they were regularifstatements.