Skip to content

HTTP/3: Make logging IDs consistent with other protocols #34745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2021
Merged

HTTP/3: Make logging IDs consistent with other protocols #34745

merged 3 commits into from
Jul 27, 2021
+70 −25

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 26, 2021

Fixes #33593

halter73
halter73 reviewed Jul 27, 2021
View reviewed changes
halter73
halter73 reviewed Jul 27, 2021
View reviewed changes
@JamesNK JamesNK merged commit c2694e4 into main Jul 27, 2021
@JamesNK JamesNK deleted the jamesnk/http3-logging-ids branch July 27, 2021 20:17
@ghost ghost added this to the 6.0-rc1 milestone Jul 27, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

HTTP/3: Figure out ConnectionId, RequestId, TraceId

4 participants

@JamesNK @halter73 @amcasey