Skip to content

Use spa-templates repo as a submodule #34366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2021
Merged

Use spa-templates repo as a submodule #34366

merged 2 commits into from
Jul 15, 2021

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Jul 15, 2021

@dougbu dougbu requested review from a team, SteveSandersonMS, javiercn and mkArtakMSFT July 15, 2021 04:19
@dougbu dougbu requested a review from Pilchie as a code owner July 15, 2021 04:19
@dougbu dougbu force-pushed the dougbu/new.submodule branch from 24c1b52 to 933731e Compare July 15, 2021 04:43
dougbu
dougbu commented Jul 15, 2021
View reviewed changes
src/ProjectTemplates/test/ProjectTemplates.Tests.csproj Outdated
Copy link
Contributor Author

@dougbu dougbu Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference to Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj is insufficient to restore, build, or pack that template project when using src\ProjectTemplates\build.cmd or src/ProjectTemplates/build.sh. I had to modify those files ☹️

src/submodules/Directory.Build.props Outdated
Copy link
Contributor Author

@dougbu dougbu Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I update the spa-template repo to build outside the aspnetcore repo, I'll make this logic unnecessary.

@dougbu dougbu mentioned this pull request Jul 15, 2021
Closed
4 tasks
wtgodbe
wtgodbe approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 15, 2021
@dougbu dougbu merged commit 0d6b223 into main Jul 15, 2021
@dougbu dougbu deleted the dougbu/new.submodule branch July 15, 2021 17:16
@ghost ghost added this to the 6.0-preview7 milestone Jul 15, 2021
@dougbu dougbu mentioned this pull request Jun 18, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@javiercn javiercn Awaiting requested review from javiercn

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

6.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@dougbu @wtgodbe @Pilchie