HTTP/3: Complete outbound control stream with connection #33956
Merged
+58
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
Tratcher
approved these changes
Jun 30, 2021
halter73
reviewed
Jun 30, 2021
|
|
||
| lock (_sync) | ||
| { | ||
| OutboundControlStream?.Abort(connectionError, (Http3ErrorCode)_errorCodeFeature.Error); |
Member
There was a problem hiding this comment.
Is the lock really necessary? If we see a stale null OutboundControlStream, is it wrong to treat it as if it hadn't been fully created? I know this lock was there before and it doesn't really hurt if it's generally uncontested. I'm just curious.
Member
Author
There was a problem hiding this comment.
It's probably not necessary. Can look at cleaning it up in the future.
halter73
approved these changes
Jun 30, 2021
|
Hello @JamesNK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
Author
|
/azp build |
|
Command 'build' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Member
Author
|
/asp run |
JamesNK
force-pushed
the
jamesnk/http3-connectionshutdown-controlstream
branch
from
0fa84bc to
77fb3af
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
merged commit 
amcasey
added
area-networking
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the outbound control stream is completed when the connection is completed.
(right now it is completed via Stream.Abort, future issue will cover graceful shutdown)