Skip to content

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Jun 21, 2021

Bug fix for #33433 which was recently merged. Service parameters do not belong in an endpoint's ApiDescription.

Before:

image

After:

image

Addresses #33685

@halter73 halter73 added area-runtime feature-minimal-actions Controller-like actions for endpoint routing labels Jun 21, 2021
@halter73 halter73 requested review from davidfowl and pranavkm June 21, 2021 22:31
@halter73 halter73 requested a review from javiercn as a code owner June 21, 2021 22:31
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 21, 2021
@halter73
Copy link
Member Author

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/958707437

@kdcllc
Copy link

kdcllc commented Jun 25, 2021

@halter73 how do we get the latest bits for minimal apis? We are working on an api that we would love to being using it.

@ghost
Copy link

ghost commented Jun 25, 2021

Hi @kdcllc. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@halter73
Copy link
Member Author

@kdcllc Your best bet is probably using a "main (6.0.x Runtime)" or "Release/6.0.1XX-preview6 (6.0.x Runtime)" installer from https://github.com/dotnet/installer

@kdcllc
Copy link

kdcllc commented Jun 25, 2021

@halter73 Great, that is exactly what I did. Thank you very much!

@ghost
Copy link

ghost commented Jun 25, 2021

Hi @kdcllc. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-minimal-actions Controller-like actions for endpoint routing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants