Skip to content

Propogate repair commands to inner bundles in Hosting Bundle #33588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Propogate repair commands to inner bundles in Hosting Bundle #33588

merged 1 commit into from
Jun 18, 2021

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 16, 2021

Should fix #33572

@joeloff how can I test this once I have a build?

@wtgodbe wtgodbe requested review from a team and joeloff June 16, 2021 21:05
@wtgodbe wtgodbe requested a review from Pilchie as a code owner June 16, 2021 21:05
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 16, 2021
joeloff
joeloff approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@joeloff joeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick turn around

@wtgodbe wtgodbe changed the title Propagate repair commands to inner bundles in Hosting Bundle Propogate repair commands to inner bundles in Hosting Bundle Jun 17, 2021
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 17, 2021

/backport to release/5.0

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 17, 2021

/backport to release/3.1

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 17, 2021

/backport to release/2.1

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/947134773

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/947134957

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2021

Started backporting to release/2.1: https://github.com/dotnet/aspnetcore/actions/runs/947135135

This was referenced Jun 17, 2021
Merged
Closed
Merged
@joeloff
Copy link
Member

joeloff commented Jun 17, 2021

Should fix #33572

@joeloff how can I test this once I have a build?

Clean machine is best, just to make it easier to find the logs. Install the hosting bundle, then from a commandline, run the bundle with /repair /quiet.

In the repair log of the hosting bundle you should see it invoking the dotnet runtime bundles with /repair. But if it did, you should also see setup logs from the runtime bundle appearing in %temp%.

@wtgodbe wtgodbe merged commit 1ead769 into main Jun 18, 2021
@wtgodbe wtgodbe deleted the wtgodbe/HostProp branch June 18, 2021 17:44
@ghost ghost added this to the 6.0-preview7 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeloff joeloff joeloff approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

+1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

6.0-preview7

Development

Successfully merging this pull request may close these issues.

Hosting bundle does not propagate repair commands to inner bundles

4 participants

@wtgodbe @joeloff @dougbu