Fix script/link tests #33453
Fix script/link tests #33453
Conversation
ghost
added
the
area-mvc
|
|
||
| <!-- Globbed script tag with existing files and version --> | ||
| <script asp-src-include="**/*.js" asp-append-version="true"> | ||
| <script asp-src-include="**/styles/**/*.js" asp-append-version="true"> |
There was a problem hiding this comment.
Do we actually put JavaScript under the styles directory? Seems weird...
There was a problem hiding this comment.
I don't really have any more context than you, but this is the expected styles directory https://github.com/dotnet/aspnetcore/tree/main/src/Mvc/test/WebSites/HtmlGenerationWebSite/wwwroot/styles, the issues it that all the test websites get their wwwroots combined when I did the helix conversion, since they all got squashed together, so **/*.js finds a bunch of extra files. I don't really have a simple fix for that, so I just updated it to look at the styles directory 🤷
|
Updated to fix globbing taghelper test which had similar issues with script wildcards (fix was explicitly excluding the additional unexpected libraries from the test websites) |
|
I'm leaving taghelpers out of this PR to get this in, @captainsafia does this look reasonable to merge as is? The jist of the diffs is all the script files for all the functional test websites show up now due to helix publishing, so these tests with wildcards need to be hand tweaked to exclude the unexpected files |
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Looks fine.
Are we tracking re-enabling the TagHelpers tests somewhere?
|
Yeah I'll leave #29597 open and just update it to say taghelpers are left |
Part of #29597
Moving to helix merged the websites so there are additional css/js files, more tightly scoping the globs avoids the additional js/css files