Skip to content

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Jun 3, 2021

#32162 caused the tests modified by this PR to fail pretty consistently on local debug builds for me and @Tratcher at least.

Fixes #33237

@halter73 halter73 requested review from JamesNK and Tratcher June 3, 2021 18:18
@halter73 halter73 requested a review from BrennanConroy as a code owner June 3, 2021 18:18
@ghost ghost added the area-runtime label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Hello @halter73!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'd just remove the 5 second change, 30 seconds isn't really that long, and if you're doing active development that might hang things, just change the default locally.

@JamesNK
Copy link
Member

JamesNK commented Jun 3, 2021

30 seconds is annoying when you’re making dev changes and you need to wait half a minute for tests to report timeouts because of regressions.

I don’t want to change a value every time I start doing dev work.

If a longer timeout is required in a select few places then just change those places.

@halter73
Copy link
Member Author

halter73 commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ghost ghost merged commit f02b25a into main Jun 3, 2021
@ghost ghost deleted the halter73/33237 branch June 3, 2021 22:42
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kestrel data rate tests failing locally

5 participants