Skip to content

Update Chrome driver #33019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2021
Merged

Update Chrome driver #33019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8536cc
Update Chrome driver
BrennanConroy May 25, 2021
761d9ba
other
BrennanConroy May 26, 2021
0e14058
diff version
BrennanConroy May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Shared/E2ETesting/selenium-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"drivers": {
"chrome": {
"version" : "89.0.4389.23"
"version" : "91.0.4472.19"
Copy link
Contributor

@JunTaoLuo JunTaoLuo May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we try to match this version and the SeleniumWebDriverChromeDriverVersion: https://www.nuget.org/packages/Selenium.WebDriver.ChromeDriver/91.0.4472.1900-beta at https://github.com/dotnet/aspnetcore/blob/main/eng/Versions.props#L250.

Copy link
Member Author

@BrennanConroy BrennanConroy May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's non-obvious what the relationship is between those two things, and I'd like to unblock builds

Copy link
Contributor

@dougbu dougbu May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relationship is mainly to the version of Chrome installed. Kestrel's Interop.FunctionalTests.csproj should fail w/ the current version or will real soon now. Plz fix if possible though separate PR may be fine.

Copy link
Member Author

@BrennanConroy BrennanConroy May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone will need to add the package to the dotnet-public feed

}
},
"ignoreExtraDrivers": true
Expand Down