[release/6.0-preview5] Enable compiling with crossgen2
#33004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng linux-musl from the build
… in "Tests: Helix ARM64 matrix" job - need `node` in this job for some reason
…d only to the `crossgen` tool - may have missed a few of course nits: - `crossgen` -> `crossgen2` in a few comments - add / expand a few comments to improve clarity
ghost
added
the
area-infrastructure
dougbu
approved these changes
May 25, 2021
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks good and hit no problems in the GitHub action
Contributor
|
@Pilchie should I set this to auto-merge❔ |
Contributor
|
/fyi @Lxiamail @davidwrighton |
Member
|
@mmitche - any objections to taking this infrastructure change in Preview5? |
Member
|
Go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #32508 to release/6.0-preview5
/cc @dougbu
Customer Impact
Testing
Risk