-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Further simplify empty project template #32662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What happens if another await is added while the blocking
Even with RunAsync, is a thread somewhere is blocked while the app is running? I don't know the mechanics of async+Main and async+top-level. |
I'm assuming that's the "worst case" where one extra blocked thread for the lifetime of the application. |
|
I'm gonna make a fix to hosting to not block forever. Also I made a fix to avoid the wait if ctrl+c does fire. In general we're going to be attempting to fix the hang so don't worry about it |
Tratcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the total character count down to now?
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I thought these tests were quarantined/disabled @captainsafia @pranavkm |
The
await usingwas unnecessary sinceRun/RunAsyncdispose internally.I'm less sure about changing the
await app.RunAsync()toapp.Run(), but it is less verbose this way and it's equivalent as long as there's no otherawaitsin the top-level statement. We could add an analyzer to suggestRunAsyncif anawaitis added as a top-level statement. Worst case is one extra blocked thread for the lifetime of the application.#32003 Was the PR started using WebApplication in the empty template.