Bump SDK and disable RSG for BasicTestApp #32581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on dotnet/sdk#17491. |
pranavkm
approved these changes
May 13, 2021
|
This is blocked on dotnet/sdk#17461 now. |
This was referenced May 14, 2021
|
To unblock this PR (and resolve the build flakiness in our repo), I'm skipping the openapi tests for now. We can revisit unskipping them at the next SDK bump if the workload stuff is resolved. There's not much churn in that area anyways so the risk should be minimal compared to the benefit of more reliable builds. |
ghost
added this to the
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31023 and maybe #32237
While we wait for the new incremental source generator API, let's disable the RSG for the BasicTestApp to avoid issues when developing locally.