Reorder HealthCheck status logging #32524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
FirstAfterGod2501
approved these changes
May 9, 2021
mkArtakMSFT
added
the
area-healthchecks
Contributor
|
Thanks for your PR. @javiercn can you please take a look at this? Thanks! |
javiercn
approved these changes
May 10, 2021
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks Good To Me
Thanks for the contribution!
mkArtakMSFT
reviewed
May 10, 2021
Co-authored-by: Artak <[email protected]>
Member
|
Looks like this ended up getting resolved as part of a logging refactor in #32414 Sorry this wasn't merged @mettelephant, we do appreciate the change though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Reorder HealthChecks logging to match previous change
PR Description
A previous PR #26575 updated the format of the health check logs but not the parameters. This should update those to match.
Addresses #32523