Execute interop and template tests on latest Fx

[dougbu]

• restore $(TestDependsOnAspNetRuntime) settings
  • needed to execute on just-built Microsoft.AspNetCore.App.Runtime
• separate from $(TestDependsOnAspNetPackages) because App.UnitTests need only the packages

[dougbu]

Looks like we're still testing against Microsoft.AspNetCore.App.Runtime bits from the SDK ☹️

[HaoK]

This seems to break all the template tests?

[dougbu]

This seems to break all the template tests?

Thanks @HaoK. I had ignored $(TestDependsOnAspNetPackages) default in Helix.props.

[HaoK]

Just so I understand the intent/distinction here, so we have a set of tests that we don't want to install the aspnet packages? What exactly does TestDependsOnAspNetRuntime affect vs the default false/false case for most tests.

[dougbu]

@HaoK the interop and template tests build and execute test asset projects using the shared framework.

$(TestDependsOnAspNetRuntime) controls the Directory.Build.* files placed in the work item root. By default, they just block builds checking containing folders. When true, the files are generated (they land in artifacts/bin/GenerateFiles/) and do things like update the @(KnownFrameworkReference) item for Microsoft.AspNetCore.App.

Put another way, test builds normally use the shared Fx carried in the SDK. When $(TestDependsOnAspNetRuntime) is true, test builds instead use the just-built shared Fx from dotnet/aspnetcore.

[HaoK]

Awesome thanks @dougbu that clarifies things for me, I wasn't sure what this switch did, now it makes sense :)

[HaoK]

Side note, maybe we could rename TestDependsOnAspNetRuntime to convey this better, TestDependsOnBuildAspNetRuntime ?

[dougbu]

maybe we could rename TestDependsOnAspNetRuntime to convey this better, TestDependsOnBuildAspNetRuntime ?

I'm not sure how that improves things and like the existing name. Perhaps $(TestBuildsDependOnAspNetRuntime) might be more accurate but not by much. Either way, I'm leaving any rename of this old property for the future.