Skip to content

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Apr 26, 2021

Fixes #14076

Open issues to follow up on:

Angular:
ng run test - fails due to office tabs popping up
npm run build:ssr - fails with "Schema validation failed with the following errors:
Data path "" should NOT have additional properties(vendorChunk)."

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 26, 2021
@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

@javiercn I hand ported the initial changes back to the templates

@HaoK HaoK requested a review from javiercn April 26, 2021 17:31
@javiercn
Copy link
Member

@HaoK this looks great, does it cover the auth options?

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

No I will do that now, and do another port, were there any differences between individual/b2c that I need to look out for? Is one a superset?

@HaoK
Copy link
Member Author

HaoK commented Apr 26, 2021

Oh never mind, looks like there's only individual auth option for spa

@HaoK HaoK marked this pull request as ready for review April 27, 2021 23:01
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good to me so far,

I think we'll have to check the generated templates to understand if there's anything that needs to be updated.

It would be great if you can generate a couple of versions of the templates (no auth and auth) and push them to a repo so that we can play with them a bit.

@HaoK
Copy link
Member Author

HaoK commented Apr 28, 2021

https://github.com/HaoK/Random/tree/haok/temp/angular6 and https://github.com/HaoK/Random/tree/haok/temp/angular6ind
are the outputs of the template I just built, the spa client apps seem to run fine, but I see some weird errors when running the whole app via dotnet run, maybe due to package restore/version issues since its looking for SpaProxy6.0.0-dev

@javiercn
Copy link
Member

https://github.com/HaoK/Random/tree/haok/temp/angular6 and https://github.com/HaoK/Random/tree/haok/temp/angular6ind
are the outputs of the template I just built, the spa client apps seem to run fine, but I see some weird errors when running the whole app via dotnet run, maybe due to package restore/version issues since its looking for SpaProxy6.0.0-dev

Let me give this a try tomorrow. I can just remove the proxy and start things manually.

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@HaoK HaoK merged commit 0011eff into main May 6, 2021
@HaoK HaoK deleted the haok/ang branch May 6, 2021 16:52
@ghost ghost added this to the 6.0-preview5 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to the latest Angular version

3 participants