Skip to content

HTTP/2: Fix flakey response rate timeout tests #32139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

HTTP/2: Fix flakey response rate timeout tests #32139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8df7d5
HTTP/2: Fix flakey response rate timeout tests
JamesNK Apr 24, 2021
1bf17c8
Clean up
JamesNK Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Connections;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Server.Kestrel.Core.Features;
using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2;
using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
Expand Down Expand Up @@ -332,6 +333,29 @@ await WaitForConnectionErrorAsyncDoNotCloseTransport<Http2ConnectionErrorExcepti
_pair.Application.Output.Complete();
}

private class EchoAppWithNotification
{
private readonly TaskCompletionSource _writeStartedTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

public Task WriteStartedTask => _writeStartedTcs.Task;

public async Task RunApp(HttpContext context)
{
await context.Response.Body.FlushAsync();

var buffer = new byte[Http2PeerSettings.MinAllowedMaxFrameSize];
int received;

while ((received = await context.Request.Body.ReadAsync(buffer, 0, buffer.Length)) > 0)
{
var writeTask = context.Response.Body.WriteAsync(buffer, 0, received);
_writeStartedTcs.TrySetResult();

await writeTask;
}
}
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/21520")]
public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod()
Expand All @@ -347,7 +371,8 @@ public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsC

_timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks);

await InitializeConnectionAsync(_echoApplication);
var app = new EchoAppWithNotification();
await InitializeConnectionAsync(app.RunApp);

await StartStreamAsync(1, _browserRequestHeaders, endStream: false);
await SendDataAsync(1, _helloWorldBytes, endStream: true);
Expand All @@ -357,6 +382,8 @@ await ExpectAsync(Http2FrameType.HEADERS,
withFlags: (byte)Http2HeadersFrameFlags.END_HEADERS,
withStreamId: 1);

await app.WriteStartedTask.DefaultTimeout();

// Complete timing of the request body so we don't induce any unexpected request body rate timeouts.
_timeoutControl.Tick(mockSystemClock.UtcNow);

Expand Down Expand Up @@ -400,7 +427,8 @@ public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnLargeWrite_AbortsC

_timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks);

await InitializeConnectionAsync(_echoApplication);
var app = new EchoAppWithNotification();
await InitializeConnectionAsync(app.RunApp);

await StartStreamAsync(1, _browserRequestHeaders, endStream: false);
await SendDataAsync(1, _maxData, endStream: true);
Expand All @@ -410,6 +438,8 @@ await ExpectAsync(Http2FrameType.HEADERS,
withFlags: (byte)Http2HeadersFrameFlags.END_HEADERS,
withStreamId: 1);

await app.WriteStartedTask.DefaultTimeout();

// Complete timing of the request body so we don't induce any unexpected request body rate timeouts.
_timeoutControl.Tick(mockSystemClock.UtcNow);

Expand Down