Set some new Wasm properties so the Sdk can use Workloads when available #32036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
What is going on with CI in this PR? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
@lewing Looks like this PR happened during a period when CI was behaving badly. I've asked it to restart the CI run. @pranavkm You're the main expert about this on the Blazor side, so can you approve if you're happy with it? From my point of view this looks fine and I would just approve it, but want to make sure you've had a chance to see it first. |
Member
Author
|
Rebased to get CI green, cc @pranavkm |
Member
Author
|
@danroth27 thoughts on the description? |
pranavkm
approved these changes
Apr 27, 2021
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Description is fine by me. FYI @danroth27 for input
Member
|
Merging to keep things moving, but we can tweak the description further later if @danroth27 has feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdk part in dotnet/sdk#17092
This doesn't change any behavior without the sdk change but, with the sdk change it allows the Browser build to enable runtime relink/build outside of RunAOTCompilation during publish. Enabling additional features and/or size reductions in a published app.