Skip to content

[release/5.0] Remove MusicStore #31818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

[release/5.0] Remove MusicStore #31818

merged 1 commit into from
May 4, 2021
+20 −38,765

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 14, 2021

nit: rearrange the Framework folder in our solution

  • remove the single-project App.Runtime folder
  • add new App.Ref folder
  • add Microsoft.AspNetCore.App.Ref.Internal.csproj to the solution in new App.Ref folder

@dougbu
[release/5.0] Remove MusicStore
2e82376 
nit: rearrange the Framework folder in our solution
- remove the single-project App.Runtime folder
- add new App.Ref folder
- add Microsoft.AspNetCore.App.Ref.Internal.csproj to the solution in new App.Ref folder
@dougbu dougbu added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 14, 2021
@dougbu dougbu added this to the 5.0.7 milestone Apr 14, 2021
@dougbu dougbu requested a review from a team April 14, 2021 23:43
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 14, 2021
@dougbu
Copy link
Contributor Author

dougbu commented Apr 14, 2021

Again,

This isn't incredibly urgent. But, might be nice to get it into 3.1.15 5.0.5 if dependency flow_ hasn't reached this repo by the time the changes are approved and validated.
/fyi @mkArtakMSFT
/btw this is tell-mode because it only affects samples and tests.

@dougbu dougbu mentioned this pull request Apr 14, 2021
Merged
@wtgodbe wtgodbe merged commit e6998cb into release/5.0 May 4, 2021
@wtgodbe wtgodbe deleted the dougbu/thedaythemusicdied.5.0 branch May 4, 2021 23:05
@wtgodbe wtgodbe mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

5.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@dougbu @pranavkm @wtgodbe