Skip to content

Update Polly and support IConcurrentPolicyRegistry<string> #31708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2021
Merged

Update Polly and support IConcurrentPolicyRegistry<string> #31708

merged 2 commits into from
Apr 14, 2021

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Apr 12, 2021

PR Title

Update to the latest release of Polly.

PR Description

Addresses #31705

@martincostello
Update Polly version
9eb9e6f 
Update Polly dependency to the latest version of the package.
Addresses dotnet#31705.
@martincostello
Add support for IConcurrentPolicyRegistry
5a3193e 
Also register Polly policies as IConcurrentPolicyRegistry<string>.
Addresses dotnet#28283 (comment).
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 12, 2021
@martincostello
Copy link
Member Author

martincostello commented Apr 12, 2021

The latest release of Polly isn't in the Azure Artifacts feed, so I tested this locally with this added to NuGet.config:

<add key="nuget-public" value="https://api.nuget.org/v3/index.json" />

javiercn
javiercn approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for the contribution!

@Pilchie Pilchie added area-runtime feature-httpclientfactory Includes: HttpClientFactory (some bugs also in Extensions repo) labels Apr 12, 2021
@dougbu
Copy link
Contributor

dougbu commented Apr 12, 2021

The latest release of Polly isn't in the Azure Artifacts feed

@mmitche @wtgodbe could you please help here❔

@wtgodbe
Copy link
Member

wtgodbe commented Apr 12, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 12, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@BrennanConroy BrennanConroy added this to the 6.0-preview4 milestone Apr 14, 2021
@BrennanConroy BrennanConroy merged commit 5e71c23 into dotnet:main Apr 14, 2021
@BrennanConroy BrennanConroy mentioned this pull request Apr 14, 2021
Closed
@martincostello martincostello deleted the Update-Polly-31705 branch April 14, 2021 17:33
@martincostello martincostello mentioned this pull request Jun 1, 2021
Merged
@martincostello martincostello mentioned this pull request Aug 10, 2021
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

Assignees

@javiercn javiercn

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member feature-httpclientfactory Includes: HttpClientFactory (some bugs also in Extensions repo)

Projects

None yet

Milestone

6.0-preview4

Development

Successfully merging this pull request may close these issues.

7 participants

@martincostello @dougbu @wtgodbe @javiercn @Pilchie @BrennanConroy @amcasey