Fix UnexpectedFrameError flaky tests #31707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JamesNK
changed the title
Tratcher
approved these changes
Apr 13, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
This helps because the test client is checking the error code directly after the goaway rather than waiting for the connection to close (abort)? Should the client be waiting instead?
Member
Author
|
Right now I'm not sure what is most appropriate. System.Net.Quic is refactoring how aborts are handled so I think we should wait until they are done before digging into this scenario. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31501
Fixes #31388