Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 1, 2021

Part of #18873

@ghost ghost added area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member labels Apr 1, 2021
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Could you also take a look at the Crankier folder? Looks like it got missed.
https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/perf/benchmarkapps/Crankier

@mkArtakMSFT
Copy link
Contributor

Thanks for your PR.

Unfortunately, we can't take this PR as it's related to the licensing comments. These are things we're working on already so we'll have to close this.

Thanks for your effort.

@mkArtakMSFT mkArtakMSFT closed this Apr 1, 2021
@Youssef1313
Copy link
Member Author

Looks good!

Could you also take a look at the Crankier folder? Looks like it got missed.
https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/perf/benchmarkapps/Crankier

Going to take a look why/how it was missed. This was literally a FixAll application from the command line.

@ghost
Copy link

ghost commented Apr 1, 2021

Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@Youssef1313
Copy link
Member Author

Thanks for your PR.

Unfortunately, we can't take this PR as it's related to the licensing comments. These are things we're working on already so we'll have to close this.

Thanks for your effort.

@mkArtakMSFT Please see the discussion in #30132

@ghost
Copy link

ghost commented Apr 1, 2021

Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@Youssef1313
Copy link
Member Author

Looks good!

Could you also take a look at the Crankier folder? Looks like it got missed.
https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/perf/benchmarkapps/Crankier

@BrennanConroy It was missed because it doesn't exist in SignalR.slnf nor in AspNetCore.sln.

@ghost
Copy link

ghost commented Apr 1, 2021

Hi @Youssef1313. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants