Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 4, 2021

Because of the current state, the whole NuGetCommand gets passed as an artifact parameter to default-build.yml, which causes it to upload the whole build directory as an artifact (and skip the Push Visual Studio packages step entirely)

@wtgodbe wtgodbe requested a review from a team March 4, 2021 01:15
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2021
@wtgodbe wtgodbe merged commit 3b1fd90 into release/3.1 Mar 4, 2021
@wtgodbe wtgodbe deleted the wtgodbe/MoveBlock branch March 4, 2021 01:17
@JunTaoLuo
Copy link
Contributor

:shipit:

@dougbu
Copy link
Contributor

dougbu commented Mar 4, 2021

Oops, putting artifacts in the middle of the steps is nasty. Think I commended on this on @JunTaoLuo's PR but missed the impact (thought it just placed artifacts before steps) 🤦

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants