[Java] Fix skip negotiate null ref #30574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Mar 2, 2021
| if (this.skipNegotiate) { | ||
| if (this.transportEnum != TransportEnum.WEBSOCKETS) { | ||
| throw new RuntimeException("Negotiation can only be skipped when using the WebSocket transport directly with '.withTransport(TransportEnum.WEBSOCKETS)' on the 'HubConnectionBuilder'."); | ||
| } |
Member
There was a problem hiding this comment.
You must have removed this from #30482 after I approved it. Could it break any previously-working code?
Member
Author
There was a problem hiding this comment.
Yeah, if you didn't specify a transport and used skip negotiate, it would work because WebSockets will be used first. So adding that check would have broken people that had it working but didn't explicitly specify the transport.
halter73
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #30482 with the additional WebSocket check.