Fix h1-4 in identity ui for accessibility #29706
Conversation
ghost
added
the
| } | ||
|
|
||
| <h2>@ViewData["Title"]</h2> | ||
| <h1>@ViewData["Title"]</h1> |
There was a problem hiding this comment.
@HaoK this likely changes the visuals, are PMs ok with the new visual aspect?
We can use the h2 and so on Bootstrap classes to keep the visual aspect the same while being correct about the markup.
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
LGTM if we are ok with the visual change on the page.
|
@blowdart can you review as well since there might be some visual diffs |
|
Can someone put together screen shots? I don't have anything set up to build new builds right now. |
|
After
|
|
Pretty hard to notice if you ask me :) I can't even really tell with the tabs side by side, but the text is bigger |
|
So the net result is we bumped up the size of the text basically across the board with these changes |
|
Manage your account grows etc. This is fine by mine to be honest. Go for it. |
Fixes #25674
Basic summary is that we should use h1-h6 in sequential order, note for the manage pages, the layout uses h1-h2, so those pages start at h3.
Will need to port these changes to scaffolding as well