Fix issue with cert being finalized in data protection test #29097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
changed the title
HaoK
commented
Jan 7, 2021
captainsafia
reviewed
Jan 7, 2021
| } | ||
|
|
||
| WithUniqueTempDirectory(directory => | ||
| using (var imported = new X509Certificate2(filePath, "password", X509KeyStorageFlags.Exportable)) |
captainsafia
approved these changes
Jan 7, 2021
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
It looks like the only meaningful change is wrapped up the certificate reference in a disposable clause.
That seems like a reasonable fix for the memory issue to me.
|
Hello @HaoK! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
pranavkm
approved these changes
Jan 8, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26871
Root cause appears to be Arm64 having less memory so the cert was getting finalized, see #26871 (comment) for more details