Skip to content

[release/3.1] Include Portugese loc resources in bundles #29065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

[release/3.1] Include Portugese loc resources in bundles #29065

merged 1 commit into from
Jan 13, 2021

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 5, 2021

Should resolve #25763

We have loc resources for Portuguese, but don't actually reference them from the bundle files - this should fix that issue.

@wtgodbe wtgodbe requested review from a team and joeloff January 5, 2021 20:54
@ghost ghost added the feature-installers Includes: Installers label Jan 5, 2021
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 5, 2021
@wtgodbe wtgodbe added this to the 3.1.12 milestone Jan 5, 2021
dougbu
dougbu approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit description when merging. This PR adds en-US / default English / 1033 resources to the bundle. #25763 happens due to a fallback after the installer finds English resources are missing.

@wtgodbe wtgodbe merged commit 0a8a394 into release/3.1 Jan 13, 2021
@wtgodbe wtgodbe deleted the wtgodbe/31Portuguese branch January 13, 2021 18:25
@wtgodbe wtgodbe mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeloff joeloff Awaiting requested review from joeloff

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature-installers Includes: Installers tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

3.1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @dougbu