Added WebAssembly capability to Blazor WebAssembly projects
#28714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkArtakMSFT
requested review from
a team and
SteveSandersonMS
as code owners
ghost
added
the
Contributor
Author
|
@BillHiebert can you please confirm this is what you are looking for to fix the gRPC reference issue in VS? |
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
leecow
added
Servicing-approved
Contributor
Author
|
@vijayrkn looks like @BillHiebert is out. Please assign someone to review this. Thanks! |
vijayrkn
approved these changes
Jan 7, 2021
Contributor
Author
|
@wtgodbe I should merge this? |
Member
Not yet, branches don't open until Tuesday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VS has a feature of adding gRPC service reference to a project using UI. Currently that experience has no easy way to differentiate between Blazor Server and Blazor WebAssembly projects. As a result, adding gRPC reference using VS feature adds the wrong gRPC package (Grpc.AspNetCore), instead of adding
Grpc.Net.ClientandGrpc.Net.Client.Web, per our documentation. The package which is wrong adds framework reference transitively, which is not supported on WebAssembly.This change adds a unique WebAssembly capability to all Blazor WebAssembly projects (through the SDK) so VS can build unique experiences those projects and also address that bug.
Customer Impact
This particular change has no customer impact, but it will enable VS to fix their experience tracked by this AzDO issue
Regression?
Risk
[Justify the selection above]
Verification
Not applicable as this change has no functional impact. The follow-up change is on the VS side to utilize this change and differentiate projects.
Packaging changes reviewed?
Addresses #28716