Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 9, 2020

Fixes #28538

Note: 2.34.0 (non-preview) isn't on NuGet yet. PR won't be merged until it is published and the template tests pass. 2.34.0 published

Description

There is a bug in Grpc.Tools for MacOS Big Sur that prevents gRPC tooling working. This is fixed in an update of Grpc.Tools. This PR updates the templates to use a fixed gRPC version.

Customer impact

gRPC template is broken on MacOS Big Sur. Customers can update their NuGet package versions to fix.

Regression

No.

Risk

Low. Only updates package versions in templates.

@JamesNK JamesNK added Servicing-consider Shiproom approval is required for the issue area-grpc Includes: GRPC wire-up, templates labels Dec 9, 2020
@JamesNK JamesNK added this to the 5.0.2 milestone Dec 9, 2020
@JamesNK JamesNK requested a review from dougbu as a code owner December 9, 2020 22:12
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Dec 10, 2020
@wtgodbe
Copy link
Member

wtgodbe commented Dec 11, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Member

wtgodbe commented Dec 11, 2020

@JamesNK today is the last day to get this in for 5.0.2, is there anything more that needs to be done on this PR? 5 jobs were red before I re-queued.

@shirhatti @JunTaoLuo could someone review this today?

@JamesNK
Copy link
Member Author

JamesNK commented Dec 11, 2020

The new package (2.34.0) is on NuGet now. Build is green

@wtgodbe wtgodbe merged commit bbc2e9f into release/5.0 Dec 11, 2020
@wtgodbe wtgodbe deleted the jamesnk/5.0-grpc-2.34 branch December 11, 2020 20:47
@mrward
Copy link
Contributor

mrward commented Sep 28, 2021

Will this be ported to .NET 6? The .NET 6 templates seem to be using the older grpc package.

 <PackageReference Include="Grpc.AspNetCore" Version="2.32.0" />

@ghost
Copy link

ghost commented Sep 28, 2021

Hi @mrward. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-grpc Includes: GRPC wire-up, templates area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants