Skip to content

Added null validation in RedirectHandler #28276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Added null validation in RedirectHandler #28276

merged 2 commits into from
Dec 2, 2020

Conversation

@josercadena
Copy link
Contributor

@josercadena josercadena commented Dec 1, 2020

Summary of the changes

  • Added null check to response.headers.location to prevent NullReferenceException in RedirectHandler class

Addresses #27035

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 1, 2020
campersau
campersau reviewed Dec 2, 2020
View reviewed changes
@josercadena
Copy link
Contributor Author

josercadena commented Dec 2, 2020

Thank you @campersau, just pushed the suggested commit 👍

@mkArtakMSFT mkArtakMSFT added the community-contribution Indicates that the PR has been added by a community member label Dec 2, 2020
@pranavkm pranavkm merged commit fc70b25 into dotnet:master Dec 2, 2020
@pranavkm pranavkm added this to the 6.0-preview1 milestone Jan 12, 2021
@pranavkm pranavkm mentioned this pull request Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

+1 more reviewer

@campersau campersau campersau left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@javiercn javiercn

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0-preview1

Development

Successfully merging this pull request may close these issues.

5 participants

@josercadena @campersau @javiercn @pranavkm @mkArtakMSFT