Skip to content

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Oct 14, 2020

Addresses #24922.

The tests appear to be failing because the "Scroll to the bottom" invocation wasn't completing by the time the check was made. I added an additional assertion to make sure that we've scrolled to the bottom by waiting until the last element is displayed.

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Oct 14, 2020
@captainsafia captainsafia marked this pull request as ready for review October 14, 2020 23:24
@captainsafia captainsafia requested review from a team and SteveSandersonMS as code owners October 14, 2020 23:24
@pranavkm pranavkm added this to the 6.0.0-alpha1 milestone Oct 14, 2020
@ghost
Copy link

ghost commented Oct 14, 2020

Hello @captainsafia!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 100f687 into master Oct 19, 2020
@ghost ghost deleted the safia/fix-virtualize-test branch October 19, 2020 11:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants