[wasm][debugger] Fix debug using embedded PDBs. #26899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
thaystg
changed the title
|
|
||
| export function hasDebuggingEnabled() { | ||
| return hasReferencedPdbs && currentBrowserIsChrome; | ||
| return currentBrowserIsChrome; |
Member
There was a problem hiding this comment.
Ah! I see why this would be the root cause of the user reported issue.
However, this is check is too liberal now and we'll end up running with debugging enabled if the user is running a publish app (which doesn't add any PDBs to the blazor.boot.json).
We'll probably need a more conservative check that accounts for the environment the app is running in and other properties in the boot.json.
I can make these modifications on top of your PR.
Thanks for looking at this!
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it's using embedded PDBs it will not have pdb files, but it is still possible to debug, removing the check of existence of PDB files.
Addresses #26877