Lift OIDC and JwtBearer dependencies in templates #26390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplementing the changes originally included in #24600
ghost
added
the
area-mvc
JunTaoLuo
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Contributor
Author
Tratcher
approved these changes
Sep 28, 2020
| <!--#if (OrganizationalAuth || IndividualB2CAuth || EnableOpenAPI) --> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="${MicrosoftAspNetCoreAuthenticationJwtBearerPackageVersion}" NoWarn="NU1605" /> |
Member
There was a problem hiding this comment.
When would this be a downgrade? Isn't Identity.Web always referencing an earlier version?
Member
|
👀 |
This was referenced Sep 28, 2020
leecow
removed
the
Servicing-consider
Member
|
@leecow meant to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplementing the changes originally included in #24600
This is needed since currently there's a circular dependency between the Identity.Web packages and the AspNetCore packages. To ensure the templates uses the RTM versions regardless of what Identity.Web depends on, we need to lift the versions of the OIDC and JwtBearer packages in our templates.