Remove Microsoft.Components.Web.Extensions #26256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package was marked as non-shipping but we continued to build and test it. This change removes it. A copy of this code exists in asplabs so all is not lost.
pranavkm
force-pushed
the
prkrishn/remove-non-shipping
branch
from
af84749 to
e8ab6b0
Compare
HaoK
approved these changes
Sep 24, 2020
Contributor
Author
|
@dotnet/aspnet-build we could port this change this from the 5.0 branch to reduce build times and remove some tests that are currently quarantined. Could I get this in to the rc2 branch? |
Contributor
Member
|
I'm generally supportive. What are the changes to the .js files about? |
Contributor
Author
|
The JS files are checked-in build outputs of our TS files. The ones in master are incorrect (looks like a bad merge). |
Contributor
Author
|
Let me prep a rc2 change. The JS changes shouldn't be part of it. |
pranavkm
added a commit
that referenced
this pull request
Sep 24, 2020
The package was marked as non-shipping but we continued to build and test it. This change removes it. A copy of this code exists in asplabs so all is not lost.
dougbu
pushed a commit
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package was marked as non-shipping but we continued to build and test it. This change
removes it. A copy of this code exists in asplabs so all is not lost.