Pin PackageOverrides.txt Extensions versions at Major.Minor.0 in servicing #25986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Sep 16, 2020
dougbu
commented
- set the package version of Extensions assemblies using NETCore.App version
- ignore Microsoft.Extensions.Internal.Transport package version
- transport package has a non-stable version and isn't shipped
- just got lucky this worked before versions stabilize
- ignore Microsoft.Extensions.Internal.Transport package version
- update test expectations when checking PackageOverrides.txt
- use NuGet.Versioning to make this easier
…icing
- set the package version of Extensions assemblies using NETCore.App version
- ignore Microsoft.Extensions.Internal.Transport package version
- transport package has a non-stable version and isn't shipped
- just got lucky this worked before versions stabilize
- update test expectations when checking PackageOverrides.txt
- use NuGet.Versioning to make this easier
dougbu
added
feature-platform
Contributor
Author
|
Think I need a "from servicing readiness exercise" label |
Contributor
Author
|
/fyi @Pilchie |
wtgodbe
approved these changes
Sep 17, 2020
wtgodbe
reviewed
Sep 17, 2020
dougbu
added a commit
that referenced
this pull request
Sep 25, 2020
- doing now ensures we don't forget if we need to service targeting packs - not needed in release/3.1 because that branch still pins packages at `X.Y.0` in targeting packs - did not do bfc1ec6 / #25851 work in 3.1 because dotnet/runtime ref/ assemblies change there - revert no-longer-necessary parts of 6418c8f / #25986 - `$(MicrosoftNETCoreAppRuntimeVersion)` is now correct whenever `GeneratePackageOverrides` runs
dougbu
added a commit
that referenced
this pull request
Sep 25, 2020
* Support override of PackageOverrides.txt content in servicing - doing now ensures we don't forget if we need to service targeting packs - not needed in release/3.1 because that branch still pins packages at `X.Y.0` in targeting packs - did not do bfc1ec6 / #25851 work in 3.1 because dotnet/runtime ref/ assemblies change there - revert no-longer-necessary parts of 6418c8f / #25986 - `$(MicrosoftNETCoreAppRuntimeVersion)` is now correct whenever `GeneratePackageOverrides` runs nits: - rename `GeneratePackageConflictManifest` target to `GeneratePackageOverrides` - rename `$(PackageConflictManifestFileName)` to `$(PackageOverridesFileName)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.