Skip to content

[master] Update dependencies from dotnet/arcade #25962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2020
Merged

[master] Update dependencies from dotnet/arcade #25962

merged 3 commits into from
Sep 16, 2020

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 16, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: a6dbb97b-1d09-43d1-e8f9-08d76e1cf1e0
  • Build: 20200915.7
  • Date Produced: 9/15/2020 7:34 PM
  • Commit: fa0486ddb04a76341d822903c8977fb9fa088d1e
  • Branch: refs/heads/master

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
6c3debf 
…915.7

Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 5.0.0-beta.20459.8 -> To Version 5.0.0-beta.20465.7
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner September 16, 2020 17:27
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Sep 16, 2020
ghost
ghost approved these changes Sep 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@chcosta
Copy link
Member

chcosta commented Sep 16, 2020

Latest Arcade update is expected to break like this...

F:\workspace\_work\1\s\src\redist\targets\GenerateMSIs.targets(202,7): error MSB4064: The "Out" parameter is not supported by the "CreateLightCommandPackageDrop" task. Verify the parameter exists on the task, and it is a settable public instance property. [F:\workspace\_work\1\s\src\redist\redist.csproj] 
F:\workspace\_work\1\s\src\redist\targets\GenerateMSIs.targets(198,5): error MSB4063: The "CreateLightCommandPackageDrop" task could not be initialized with its input parameters. [F:\workspace\_work\1\s\src\redist\redist.csproj]

I'm going to prepare a fix for that failure now.

@chcosta
Copy link
Member

chcosta commented Sep 16, 2020

Investigating failure

@dotnet-maestro dotnet-maestro bot merged commit 0250c22 into master Sep 16, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-56c799fe-c022-4058-a950-80fd270c21ac branch September 16, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougbu dougbu Awaiting requested review from dougbu

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chcosta