Skip to content

Add a test to verify NewtonsoftJsonInputFormatter disposes temporary buffer #25919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2020
Merged

Add a test to verify NewtonsoftJsonInputFormatter disposes temporary buffer #25919

merged 1 commit into from
Sep 16, 2020

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Sep 15, 2020

#22342 was fixed in a patch release,
but we hadn't written a test for this at that time. This change adds a unit
test to verify this.

Fixes #22342

@pranavkm
Add a test to verify NewtonsoftJsonInputFormatter disposes temporary …
53ad48e 
…buffer

#22342 was fixed in a patch release,
but we hadn't written a test for this at that time. This change adds a unit
test to verify this.

Fixes #22342
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 15, 2020
@pranavkm pranavkm requested review from dougbu and javiercn September 15, 2020 20:18
dougbu
dougbu approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not test this. But, unfortunately you need to /azp run to pick up @jkotalik's fix

@pranavkm pranavkm merged commit 495d3b2 into master Sep 16, 2020
@pranavkm pranavkm deleted the prkrishn/add-test branch September 16, 2020 15:30
@pranavkm pranavkm added this to the 6.0.0-alpha1 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn Awaiting requested review from javiercn

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

6.0-preview1

Development

Successfully merging this pull request may close these issues.

Temporary File Leak in NewtonsoftJsonInputFormatter

3 participants

@pranavkm @dougbu