Skip to content

Reduce references to Microsoft.AspNetCore.App.Runtime.csproj #25836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2020
Merged

Reduce references to Microsoft.AspNetCore.App.Runtime.csproj #25836

merged 1 commit into from
Sep 14, 2020

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 12, 2020

  • dotnet-watch builds against runtime in the SDK
  • other projects build after runtime project due to Ref.csproj reference
    • but, when the targeting packs aren't building, there's no reason to use Ref.csproj
  • followup on 76fbd1a and 8496266, reducing parallelism in build

@dougbu
Reduce references to Microsoft.AspNetCore.App.Runtime.csproj
6b897af 
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
  - but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a and 8496266, reducing parallelism in build
@dougbu dougbu requested a review from a team September 12, 2020 00:43
dougbu
dougbu commented Sep 12, 2020
View reviewed changes
src/Tools/dotnet-watch/src/dotnet-watch.csproj
Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
PrivateAssets="All"
ReferenceOutputAssembly="false"
SkipGetTargetFrameworkProperties="true" />
Copy link
Contributor Author

@dougbu dougbu Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not useful due to $(DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp) setting earlier in this file

@dougbu
Copy link
Contributor Author

dougbu commented Sep 12, 2020

@Pilchie if approved and passes CI, tell-mode for RC2 🆗❔

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 12, 2020
@dougbu
Copy link
Contributor Author

dougbu commented Sep 12, 2020 •
edited
Loading

/fyi @pranavkm I left src\Components\WebAssembly\DevServer\src\Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj unchanged because it can't build w/o new runtime and ref installations in the 5.0.0 to 6.0.0 update. Fixing things there is holding up my (low priority) #24983 PR.

@Pilchie
Copy link
Member

Pilchie commented Sep 12, 2020

if approved and passes CI, tell-mode for RC2 🆗❔

Yes.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 12, 2020
@dougbu
Copy link
Contributor Author

dougbu commented Sep 12, 2020

/ping reviewers This PR is green and approved for tell mode.

@dougbu dougbu merged commit 6c29f44 into release/5.0-rc2 Sep 14, 2020
@dougbu dougbu deleted the dougbu/extra.runtime.builds branch September 14, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

+2 more reviewers

@pranavkm pranavkm pranavkm approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dougbu @Pilchie @pranavkm @JunTaoLuo @wtgodbe