Strip duplicates from BuiltProjectOutputGroupOutput #25785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
feature-platform
Member
Author
|
@Pilchie merging this as infra tell-mode for rc2, it's a followup for the .pdb duplicate issue (once it gets approved) |
dougbu
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #25733, resolves #25293
While #25293 did strip duplicates from
NuGetPackInput, it did not strip duplicates fromBuiltProjectOutputGroupOutput, which is also used by Nuget to calculate inputs toNuget pack. This should fix that issue as well.More test builds:
https://dev.azure.com/dnceng/internal/_build/results?buildId=810083&view=results
https://dev.azure.com/dnceng/internal/_build/results?buildId=810084&view=results
Nuget.Client uses this item here: https://github.com/NuGet/NuGet.Client/blob/3f573425ac74d90b96a61e5e85ed39a39aad8a7f/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets#L420-L428