Support primitive type/classes in HubConnection.on() #25773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
BrennanConroy
approved these changes
Sep 10, 2020
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java
Outdated
Show resolved
Hide resolved
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java
Outdated
Show resolved
Hide resolved
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Utils.java
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Sep 10, 2020
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Member
Author
|
@Pilchie can we take this for rc2? It fixes a bug where customers couldn't use primitive types in the |
Pilchie
added
Servicing-approved
Member
|
Approved for .NET 5 RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25088
Changes the
.on()method so that it handles casting to primitives, similar to what we already do ininvoke()andstream(). Also changes tests to test that this new behavior works.